Skip to content

Support additional_linker_inputs in swift_binary #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2025
Merged

Support additional_linker_inputs in swift_binary #1584

merged 6 commits into from
Nov 11, 2025
+152 −10

Conversation

@adincebic
Copy link
Contributor

@adincebic adincebic commented Sep 28, 2025

Addresses #1511

@adincebic adincebic mentioned this pull request Sep 28, 2025
Closed
@adincebic adincebic force-pushed the adin/implement-additiona_linker_inputs-attr branch from 5e49b82 to ac269f8 Compare September 28, 2025 13:19
brentleyjones
brentleyjones reviewed Sep 29, 2025
View reviewed changes
brentleyjones
brentleyjones reviewed Sep 29, 2025
View reviewed changes
@adincebic
Copy link
Contributor Author

adincebic commented Sep 29, 2025

@brentleyjones I updated the PR. I left swiftc_inputs in RunEnvironmentInfo since we probably want to be able to reference swiftc_inputs?

RunEnvironmentInfo(
            environment = expand_locations(
                ctx,
                ctx.attr.env,
                ctx.attr.swiftc_inputs + ctx.attr.additional_linker_inputs,
            ),

brentleyjones
brentleyjones approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is technically a breaking change, in a way that could be hard to fix in non-root modules, it doesn't look like any public modules was using swiftc_inputs for linker inputs. So I'm fine with this if @keith is.

@keith
Copy link
Member

keith commented Oct 15, 2025

sure, i like naming matching other rules

@adincebic adincebic force-pushed the adin/implement-additiona_linker_inputs-attr branch from 064b690 to 6f43932 Compare October 17, 2025 20:45
@adincebic adincebic enabled auto-merge (squash) October 25, 2025 11:47
@adincebic adincebic force-pushed the adin/implement-additiona_linker_inputs-attr branch from 6f43932 to 5d72c88 Compare November 11, 2025 11:04
@adincebic adincebic disabled auto-merge November 11, 2025 11:06
@adincebic adincebic merged commit 0e0e4ab into bazelbuild:master Nov 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adincebic @keith @brentleyjones